Skip to content
This repository was archived by the owner on Feb 11, 2020. It is now read-only.

Bumped dependencies#589

Open
mcollina wants to merge 2 commits into
masterfrom
bumped-dependencies
Open

Bumped dependencies#589
mcollina wants to merge 2 commits into
masterfrom
bumped-dependencies

Conversation

@mcollina

@mcollina mcollina commented Jan 7, 2017

Copy link
Copy Markdown
Collaborator

Fixes #587

@mcollina mcollina force-pushed the bumped-dependencies branch from 203ea31 to 4b6144f Compare January 9, 2017 11:45
@mcollina

mcollina commented Jan 9, 2017

Copy link
Copy Markdown
Collaborator Author

cc @behrad would you like to have a look?

@mcollina mcollina force-pushed the bumped-dependencies branch from 4b6144f to b9f2616 Compare January 9, 2017 12:41
@RobQuistNL

RobQuistNL commented Jan 24, 2017

Copy link
Copy Markdown

Please merge this.
EDIT: Skipping tests because they break? Please dont merge this.

@mcollina

Copy link
Copy Markdown
Collaborator Author

@RobQuistNL LOL, thanks! :)
So, would you like to help?

That feature is really not problematic and not MQTT related, but rather a problem in the actual tests.

This also depend on moscajs/ascoltatori#168

@wuhkuh

wuhkuh commented Mar 27, 2017

Copy link
Copy Markdown

I'm working on fixing those tests you've skipped in this commit. This patch I'm working on will update dependencies, integration of standard, issue #541, and some minor tweaks.
It might take a little bit longer before I've patched everything, because I have two busy weeks coming up. Doing a bit every day, though.

@mcollina

Copy link
Copy Markdown
Collaborator Author

@wuhkuh thank you so much. Keep up with the good work!

@wuhkuh

wuhkuh commented Apr 11, 2017

Copy link
Copy Markdown

@mcollina I'm back again, working on the patch. Exams are approaching so things tend to get slower as studying gets a higher priority now.

Anyway, on topic:
As I've read in the MQTT.js notes: 2.x.x drops support for 0.12. I've checked your commit in this PR and you've updated mqtt version despite this incompatibility. Should mosca drop support for 0.12 or should I revert this change?

How realistic is 0.12 usage, by the way? It is EOL since 2016-12-31, so my personal preference is to drop this. I'm not in charge of these choices, though.

@mcollina

Copy link
Copy Markdown
Collaborator Author

This PR drops support for 0.12 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants